Fix dataset logic #771
Merged
Fix dataset logic #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unami enumeration (#764) * adding new notebook for using fairchem models with NEBs * adding md tutorials * blocking code cells that arent needed or take too long
Codecov ReportAttention: Patch coverage is
|
zulissimeta
previously approved these changes
Jul 18, 2024
|
blocked by #770 |
mshuaibii
dismissed
zulissimeta’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two lines edited in #742
fairchem/src/fairchem/core/trainers/base_trainer.py
Line 310 in 5743a59
fairchem/src/fairchem/core/trainers/base_trainer.py
Line 332 in 5743a59
would set val and test datasets to have the same "src" as the training set in cases where they are not defined at all in a config. An explicit check that their own "src" is defined should fix the issue.